QCPR and EPPR78 #81
Merged
QCPR and EPPR78 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some problems with: * The databases don't work just yet since, I believe, we assume the path is relative the the current wd * The current implementation does not replicate the results from the paper...
Can now replicate both binary phase diagrams and pure diagrams for QCPR. Implementation is not finalised since it's quite messy and had to modify cubic equation.jl
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 89.12% 89.24% +0.11%
==========================================
Files 137 142 +5
Lines 8160 8346 +186
==========================================
+ Hits 7273 7448 +175
- Misses 887 898 +11
Continue to review full report at Codecov.
|
|
There is something weird on MacOS - Julia 1.6, but it is unrelated to the PR, all the tests on the other platforms pass |
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #79 and #78