Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54
to each site EoS model, there is now a new keyword,
assoc_options
containing anAssocOptions
struct of the form:if one need to increase the max iterations of an specific model, now you could just do:
as a byproduct,
split_model
was refactored to be a little bit more general. the only special case we do now is the references field.Also, there is take 3 of trying to improve NaN handling. the problem was that
ForwardDiff.Dual
s wasn't being processed by our customlog
(and nowsqrt
). with the new definitions, NaNMath is no longer used, and can be safely removed in a subsequent commit.It seems that our previous saturation pressure solver wasn't robust enough, as now there aren't any errors in the test suite with the default
log
implementation.i will merge after #56