-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNIFAC ether and aldehyde groups error #225
Comments
Hmm, you are right, I'm gonna check the pair parameters if that error is present too |
acording to http://www.aim.env.uea.ac.uk/aim/info/UNIFACgroups.html, HCO is the correct key for aldehyde, and CHO for ether. i'm gonna replace the keys accordingly |
longemen3000
added a commit
that referenced
this issue
Oct 31, 2023
Excellent! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
I found an error in the UNIFAC_like.csv file.
Both ether (CH-O) and aldehyde (CHO) groups are denoted as CHO. So if I want to model an aldehyde I get:
I get in return:
SingleParam{Float64}("R") with 3 components:
"H2O" => 1.7334
"CH3" => 0.6325
"CHO" => 1.1434
Being 1.1434 the R-value for the ether group and not the aldehyde.
Identifying the ether group as CH-O should fix it. ogUNIFAC and PSRK have the same problem.
The text was updated successfully, but these errors were encountered: