Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method overloading when registering new model #161

Closed
moesphere opened this issue Mar 31, 2023 · 3 comments
Closed

Method overloading when registering new model #161

moesphere opened this issue Mar 31, 2023 · 3 comments

Comments

@moesphere
Copy link

moesphere commented Mar 31, 2023

Related to this issue, when @registermodel is used, method overloading for private functions of Clapeyron must specfiy the Clapeyron namespace.

For example, in this line inside the macro definition, the content must be changed from

:(molecular_weight(model::$model,z=SA[1.0]) =comp_molecular_weight(mw(model),z))

to

:(Clapeyron.molecular_weight(model::$model,z=SA[1.0]) = Clapeyron.comp_molecular_weight(Clapeyron.mw(model),z))
@longemen3000
Copy link
Member

haah, you are helping me debug all this, thank you for that

longemen3000 added a commit that referenced this issue Apr 1, 2023
@longemen3000
Copy link
Member

closed in 0.4.9

@moesphere
Copy link
Author

haah, you are helping me debug all this, thank you for that

Nothing compared with the development of this great package by you and your collaborators. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants