Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EoS: ePC-SAFT #158

Closed
moesphere opened this issue Mar 28, 2023 · 7 comments
Closed

EoS: ePC-SAFT #158

moesphere opened this issue Mar 28, 2023 · 7 comments

Comments

@moesphere
Copy link

It would be great to implement PC-SAFT for electrolytes. Original paper and revision of ePC-SAFT.

A combination with the already implemented pharmaPCSAFT model would be benificial likewise.

@longemen3000
Copy link
Member

longemen3000 commented Mar 28, 2023

There is actually an implementation of ePCSAFT, in the EectrolyteModels branch:
https://github.com/ClapeyronThermo/Clapeyron.jl/blob/ElectrolyteModels/src/models/SAFT/PCSAFT/variants/ePCSAFT.jl
We are still looking on how to treat electrolytes in general (the revised ePCAFT can be expressed as ElectrolyteSAFT(components, puremodel = PCSAFT, rspmodel = MwAvg, ionmodel = DH)

@moesphere
Copy link
Author

Thanks for the hint to the ElectrolyteModels branch. To me, it seems that the implemented ePCSAFT model does not consider electrolytes. The reference to the corresponding article does not mention electrolytes. In the implementation of Cameretti, Sadowski, and Mollerup, (see original paper link in my comment above), an additional term for ions to the residual Helmholtz energy is added.

@longemen3000
Copy link
Member

longemen3000 commented Mar 29, 2023

hmm, weird, I remember seeing some terms in ePCSAFT, maybe it got deleted? The impl of the Debye-Huckel is a model on its own in that branch (DH)

@moesphere
Copy link
Author

Found it. Coupling pharmaPCSAFT with DH would mean to create a new model with a new parameter as there is not yet a way to treat electrolytes in general, as you mentioned above, correct?

@longemen3000
Copy link
Member

yes, ideally, that would be via the ElectrolyteSAFT wrapper

@longemen3000
Copy link
Member

@pw0908 can we close this issue?

@pw0908
Copy link
Member

pw0908 commented Nov 10, 2024

Yep!

@pw0908 pw0908 closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants