fix: Add state parameter to OIDC authorization request (#143) #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@alxlion Please review. I believe this fixes it |
This comment was marked as outdated.
This comment was marked as outdated.
This commit introduces the `state` parameter to the OIDC authentication flow to prevent CSRF attacks. The changes include generating a random state value, storing it in the session, and verifying it in the callback. This resolves an issue where OIDC login with Authelia would fail due to the missing `state` parameter. ,
Author
|
code formatted, builds,and test pass. ci should pass |
Author
|
@alxlion plz review |
Contributor
I don't want you to believe, you have to be sure. Have you tested it and confirmed that it's working? |
Author
|
@alxlion Let me go ahead and test it |
Author
|
drafting til then |
Author
|
@alxlion pls approve workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #143 - OIDC login fails with Authelia due to missing state parameter.
Problem
Authelia requires the
stateparameter in OIDC authorization requests (minimum 8 characters for entropy). The previous implementation didn't include this parameter, causinginvalid_stateerrors.Changes
generate_state/0function to create cryptographically secure 32-byte state valuesstateparameter inOidcc.create_redirect_urloptions/claim #143