Reformat shell scripts with shfmt and validate in CI #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
nathanchance
approved these changes
Apr 23, 2020
Member
nathanchance
left a comment
nathanchance
left a comment
There was a problem hiding this comment.
LGTM. Wait for Nick to comment before merging.
We should also do this in tc-build, continuous-integration, and dockerimage, do you want me to do it?
Member
Author
I can do it, I'm free right now. I'm sure you have better things to do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses mvdan/sh to enable formatting checks in CI, and correctly fails when the codestyle is incorrect, outputting a diff with fixes.
I chose the set of options that made the most sense to me, all available switches are listed here.