Skip to content

Conversation

@nathanchance
Copy link
Member

Commits should be self explanatory :)

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256sum LGTM thanks

(I assume we don't need the latest buildroot to build arm64; if that's the case, please consider splitting up such changed into separate PRs) 🌵 📧

@nathanchance
Copy link
Member Author

Sure, I can break these up into separate PRs in the future although I did it in one because the buildroot update in and of itself does not make a ton of sense without adding a new image and it does not make sense to use an RC version to build a new image when a stable version exists. Thank you both for the review!

@nathanchance nathanchance merged commit 5042d4a into ClangBuiltLinux:main Feb 9, 2021
@nathanchance nathanchance deleted the arm64be branch February 9, 2021 18:03
@nickdesaulniers
Copy link
Member

because the buildroot update in and of itself does not make a ton of sense without adding a new image

I'm fine with PRs that just upgrade what we have.

it does not make sense to use an RC version to build a new image when a stable version exists

Sure, the RC was just for early s390 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants