boot-utils: Add '--use-cbl-qemu' #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to do this in order to boot s390 kernels in our CI. The qemu binaries are hosted in a separate repo to keep things reasonable in terms of file size. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nickdesaulniers
approved these changes
Jan 27, 2021
Member
nickdesaulniers
left a comment
nickdesaulniers
left a comment
There was a problem hiding this comment.
Thanks, I'm hoping we can revert this soon. It's definitely a pressure relief valve that I would prefer not to maintain, resorting to it only when needed. 😢 🐩
Member
Author
|
Keeping the plumbing intact takes no effort and gives us an escape hatch if we ever hit a QEMU bug but I get what you are saying. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do this in order to boot s390 kernels in our CI. The qemu
binaries are hosted in a separate repo to keep things reasonable in
terms of file size.
This is part two in resolving ClangBuiltLinux/continuous-integration2#42.