run timeout in the foreground so it can be killed #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a kernel is hung, we currently have to wait the timeout to exit, (or ctrl+z, pkill timeout). For complicated reasons, running timeout from a shell script won't forward signals to timeout. Adding --foreground is the simplest option for this to work, via: https://unix.stackexchange.com/a/233685/388381 See other answers in that thread for *why* this is the case.
nathanchance
approved these changes
May 13, 2020
Member
nathanchance
left a comment
nathanchance
left a comment
There was a problem hiding this comment.
That's nifty.
The second commit is technically unnecessary, no? I think you meant "don't run qemu with a timeout when using gdb", which is already the case since --gdb implies --interactive.
I don't particularly care though, it's a micro-optimization to just avoid checking ${INTERACTIVE} until after we have checked ${GDB}.
tpimh
approved these changes
May 13, 2020
msfjarvis
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a kernel is hung, we currently have to wait the timeout to exit,
(or ctrl+z;
pkill timeout; fg). For complicated reasons, running timeoutfrom a shell script won't forward signals to timeout.
Adding --foreground is the simplest option for this to work, via:
https://unix.stackexchange.com/a/233685/388381
See other answers in that thread for why this is the case.