Skip to content

814 vds pull vdsdata incorrect sql parameters #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

814 vds pull vdsdata incorrect sql parameters #815

merged 1 commit into from
Jan 3, 2024

Conversation

@gabrielwol
Copy link
Collaborator

@gabrielwol gabrielwol commented Jan 2, 2024 •
edited
Loading

What this pull request accomplishes:

  • removed outdated parameters in create_partitions task sql functions

Issue(s) this solves:

What, in particular, needs to reviewed:

What needs to be done by a sysadmin after this PR is merged

@gabrielwol gabrielwol linked an issue Jan 2, 2024 that may be closed by this pull request
vds_pull_vdsdata.check_partitions.create_partitions incorrect sql parameters #814
Closed
@gabrielwol gabrielwol force-pushed the 814-vds_pull_vdsdata_incorrect-sql-parameters branch from 84d9184 to 2f15242 Compare January 2, 2024 20:31
@gabrielwol gabrielwol self-assigned this Jan 2, 2024
@gabrielwol gabrielwol requested a review from chmnata January 2, 2024 20:47
@gabrielwol gabrielwol marked this pull request as ready for review January 2, 2024 20:47
@gabrielwol gabrielwol added bug RESCU For VDS detector stations labels Jan 2, 2024
@gabrielwol gabrielwol requested review from tahaislam and removed request for chmnata January 2, 2024 20:48
tahaislam
tahaislam approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@tahaislam tahaislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tahaislam tahaislam merged commit dee8bb9 into master Jan 3, 2024
@tahaislam tahaislam deleted the 814-vds_pull_vdsdata_incorrect-sql-parameters branch January 3, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tahaislam tahaislam tahaislam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabrielwol gabrielwol

Labels

bug RESCU For VDS detector stations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vds_pull_vdsdata.check_partitions.create_partitions incorrect sql parameters

3 participants

@gabrielwol @tahaislam