Skip to content

802 vds pipelines taskflow api #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 3, 2024
Merged

802 vds pipelines taskflow api #804

merged 15 commits into from
Jan 3, 2024

Conversation

@gabrielwol
Copy link
Collaborator

@gabrielwol gabrielwol commented Dec 20, 2023 •
edited
Loading

What this pull request accomplishes:

A small PR to:

  • Update two VDS DAGs to use taskflow API in order to remove top level connections
  • Add doc_md by extracting the relevant section from github readme.
  • Add tags.
  • Updates readme with recent DAG updates + refresh DAG graph images.

Issue(s) this solves:

What, in particular, needs to reviewed:

  • Nothing, these DAGs were linked to my home folder for testing and have run as expected the last two days.

What needs to be done by a sysadmin after this PR is merged

  • Unlink the DAGs from Gabe's home folder.

@gabrielwol gabrielwol linked an issue Dec 20, 2023 that may be closed by this pull request
VDS Pipeline - remove top level connections using taskflow API #802
Closed
@gabrielwol gabrielwol self-assigned this Dec 20, 2023
@gabrielwol gabrielwol marked this pull request as ready for review December 21, 2023 20:50
@gabrielwol gabrielwol requested a review from tahaislam December 21, 2023 20:50
@gabrielwol gabrielwol added RESCU For VDS detector stations Airflow labels Dec 21, 2023
tahaislam
tahaislam reviewed Dec 22, 2023
View reviewed changes
tahaislam
tahaislam reviewed Dec 22, 2023
View reviewed changes
tahaislam
tahaislam reviewed Dec 22, 2023
View reviewed changes
tahaislam
tahaislam reviewed Dec 22, 2023
View reviewed changes
tahaislam
tahaislam approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tahaislam tahaislam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can merge it, if the DAGs run without any issues

I also left a few comments (not all of them need to be addressed here)

@gabrielwol gabrielwol mentioned this pull request Dec 22, 2023
Open
@tahaislam tahaislam merged commit 545739c into master Jan 3, 2024
@tahaislam tahaislam deleted the 802-vds-pipelines-taskflow-api branch January 3, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tahaislam tahaislam tahaislam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabrielwol gabrielwol

Labels

Airflow RESCU For VDS detector stations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VDS Pipeline - remove top level connections using taskflow API

3 participants

@gabrielwol @tahaislam