1268 update miovision intersection details #1269
Conversation
…as well as updated the readme
wael6954
changed the base branch from
master
to
1080-automatically-add-miovision-intersections
| GROUP BY intersection_uid; | ||
|
|
||
| -- Create index | ||
| CREATE INDEX idx_temp_intersection_uid ON temp_min_dates(intersection_uid); |
There was a problem hiding this comment.
Nice update on this sql. You don't need to add an index here because this is a very small table. Indexes work like textbook indexes, to help identify which chapter/page to look at, but in this example your textbook is one paragraph.
| @@ -0,0 +1,12 @@ | |||
| UPDATE miovision_api.intersections | |||
There was a problem hiding this comment.
Try combining the s_leg_restricted and n_leg_restricted queries. You can easily update multiple columns like UPDATE x=y, a=b, and add an else clause for the values that don't need to be updated. Same for cross st/ main st queries.
| @@ -0,0 +1,37 @@ | |||
| WITH intersections(id, intersection_name_api) AS ( | |||
There was a problem hiding this comment.
Fluff your sql please! Will send notion instructions.
…strictions files into one file
| ('3a6c4b1b-91cc-4600-8b9e-f3416839397b', 'The Queensway and The East Mall'), | ||
| ('ae52ca3c-9a25-4c2c-a726-24388616fe54', 'Lawrence Ave E and Fortune Gate'), | ||
| ('c85d49f2-bd4a-4649-b967-ce24e39ac102', 'Lawrence Ave E and Galloway Rd'), | ||
| ('0f37f5c0-9eb0-45d8-80cf-bd3d3718c2d4', 'Lawrence Ave E and Mossbank Dr'), | ||
| ('0b4e1e39-a9e9-46a3-895f-0f21924c0e54', 'Lawrence Ave E and Scarborough Golf Club Road'), | ||
| ('01150688-deb1-4565-a0da-236ed77cad12', 'Orton Park Rd and Lawrence Ave E'), | ||
| ('0726384f-e753-4826-9ef2-72a817776ca5', 'Overture Rd and Lawrence Ave E'), | ||
| ('843d1d1f-5350-4aaf-a764-ec8ebf847673', 'Greenholm Circuit and Lawrence Ave E'), | ||
| ('5de86391-7559-48e3-aa46-7cfe0b28bd05', 'The Queensway and The West Mall') |
There was a problem hiding this comment.
While I was QCing this one I noticed 3 intersections were being tagged to the same intersection at Lawrence/Yonge.
Needed to change the abbreviations to get correct matches: Greenholm Crct, Scarborough Golf Club Rd, Fortune Gt.
2 participants
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
in [volumes/miovision/sql/updates]
in [volumes/miovision/update_intersections]