Updated version comparison to only notify for older versions #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
force-pushed
the
compare-versions
branch
from
ff073dd to
73aa5ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
This changes the behavior for the "your wallet is out of date" notification to only display the notification if the version is older than the latest version. This will ensure that wallets with a newer version than we track in the neon DB do not see the notification, which has historically confused users.
How did you solve this problem?
I added the
compare-versionspackage and used it to compare the currently installed package version to the latest available version.How did you make sure your solution works?
I added tests!
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
N/A