[refactor-prompt] add config nep8

neo/Prompt/Commands/Config.py

@@ -4,6 +4,7 @@
 from neo.Prompt.Utils import get_arg
 from neo.Settings import settings
 from neo.Network.NodeLeader import NodeLeader
+from distutils import util
 import logging
 
 
@@ -17,6 +18,7 @@ def __init__(self):
         self.register_sub_command(CommandConfigVMLog())
         self.register_sub_command(CommandConfigNodeRequests())
         self.register_sub_command(CommandConfigMaxpeers())
+        self.register_sub_command(CommandConfigNEP8())
 
     def command_desc(self):
         return CommandDesc('config', 'configure internal settings')
@@ -155,7 +157,36 @@ def command_desc(self):
 
     def handle_help(self, arguments):
         super().handle_help(arguments)
-        print(f"\nCurrent settings {self.command_desc().params[0].name}: {NodeLeader.Instance().BREQPART}  {self.command_desc().params[1].name}: {NodeLeader.Instance().BREQMAX}")
+        print(f"\nCurrent settings {self.command_desc().params[0].name}:"
+              f" {NodeLeader.Instance().BREQPART} {self.command_desc().params[1].name}: {NodeLeader.Instance().BREQMAX}")
+
+
+class CommandConfigNEP8(CommandBase):
+    def __init__(self):
+        super().__init__()
+
+    def execute(self, arguments):
+        if len(arguments) != 1:
+            print("Please specify the required parameter")
+            return False
+
+        try:
+            flag = bool(util.strtobool(arguments[0]))
+        except ValueError:
+            print("Invalid option")
+            return False
+
+        settings.COMPILER_NEP_8 = flag
+        if flag:
+            print("NEP-8 compiler instruction usage is ON")
+        else:
+            print("NEP-8 compiler instruction usage is OFF")
+
+        return True
+
+    def command_desc(self):
+        p1 = ParameterDesc('attribute', 'either "on"|"off" or 1|0')
+        return CommandDesc('nep8', 'toggle using NEP-8 compiler instructions', [p1])
 
 
 class CommandConfigMaxpeers(CommandBase):
@@ -171,7 +202,7 @@ def execute(self, arguments):
                 return c1
             except ValueError:
                 print("Please supply a positive integer for maxpeers")
-                return                
+                return
         else:
             print(f"Maintaining maxpeers at {settings.CONNECTED_PEER_MAX}")
             return

neo/Prompt/Commands/tests/test_config_commands.py

@@ -177,3 +177,49 @@ def test_config_maxpeers(self):
         args = ['maxpeers', "-1"]
         res = CommandConfig().execute(args)
         self.assertFalse(res)
+
+    def test_config_nep8(self):
+        # test with missing flag argument
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8']
+            res = CommandConfig().execute(args)
+            self.assertFalse(res)
+            self.assertIn("Please specify the required parameter", mock_print.getvalue())
+
+        # test with invalid option
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8', 'blah']
+            res = CommandConfig().execute(args)
+            self.assertFalse(res)
+            self.assertIn("Invalid option", mock_print.getvalue())
+
+        # ideally for the next tests we should compile some SC and validate if NEP-8 instructions are used or not
+        # for now the effort required to do so does not seem justified and we'll just rely on applying the setting
+
+        # test turning on - 1
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8', 'on']
+            res = CommandConfig().execute(args)
+            self.assertTrue(res)
+            self.assertIn("NEP-8 compiler instruction usage is ON", mock_print.getvalue())
+
+        # test turning on - 2
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8', '1']
+            res = CommandConfig().execute(args)
+            self.assertTrue(res)
+            self.assertIn("NEP-8 compiler instruction usage is ON", mock_print.getvalue())
+
+        # test turning off - 1
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8', 'off']
+            res = CommandConfig().execute(args)
+            self.assertTrue(res)
+            self.assertIn("NEP-8 compiler instruction usage is OFF", mock_print.getvalue())
+
+        # test turning off - 2
+        with patch('sys.stdout', new=StringIO()) as mock_print:
+            args = ['nep8', '0']
+            res = CommandConfig().execute(args)
+            self.assertTrue(res)
+            self.assertIn("NEP-8 compiler instruction usage is OFF", mock_print.getvalue())