This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Gracefully handle NEP-5 balance query failures #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I think we should merge this into |
jseagrave21
added a commit
to jseagrave21/neo-python
that referenced
this pull request
Dec 11, 2018
Gracefully handle NEP-5 balance query failures (CityOfZion#744)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Say you have a wallet with "custom token x", that you've been developing on your network. If you switch network (e.g. to mainnet or a place that does not have that token) and try to use
walletto view the contents it will throw a flurry of exceptions.How did you solve this problem?
apply error checking, print a useful error message.
How did you make sure your solution works?
make testAre there any special changes in the code that we should be aware of?
test_invokenow returns an additional boolean indicating the VM execution statusPlease check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)