This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Fix a couple of tests #652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
There are a couple of tests that didn't work as intended under certain conditions, had uncaught exceptions or otherwise. This cleans up a couple of them
This test was passing but internally had an exception that shows up in logs
neo-python/neo/Prompt/Commands/tests/test_send_command.py
Line 91 in 773e57e
This test would cause a
404
error on downloading, while actually expected it kept triggering me to look into why.https://github.com/CityOfZion/neo-python/blob/master/neo/Prompt/Commands/tests/test_bootstrap.py#L24
This test would fail if your configured theme is
light
instead of the defaultdark
neo-python/neo/test_preferences.py
Line 22 in 773e57e
one test used the deprecated
assertEquals
instead ofassertEqual
which kept throwing a warningthe
BlockchainFixtureTestCase
andWalletFixtureTestCase
relied on running the tests from the root folder. My IDE (PyCharm) executes from whatever file I pressrun test
and for tests using either of the before mentioned cases it would fail to find wallets due to the relative path construction e.g.neo-python/neo/Utils/WalletFixtureTestCase.py
Lines 14 to 15 in 773e57e
How did you solve this problem?
assertEqual
How did you make sure your solution works?
make test
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)