HP-894: Apollo client update #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #223 +/- ##
===========================================
+ Coverage 76.38% 76.55% +0.16%
===========================================
Files 121 121
Lines 2181 2188 +7
Branches 484 483 -1
===========================================
+ Hits 1666 1675 +9
+ Misses 386 385 -1
+ Partials 129 128 -1
Continue to review full report at Codecov.
|
akikoskinen
suggested changes
Dec 9, 2021
Apollo converts props in headers into lowercase, so tests started to fail. Fixed the failing test and also changed the property name in middleware to avoid confusion.
Since Apollo converts the property to "authorization", same should be used everywhere to avoid confusion. Header properties are case-insensitive in the http spec.
NikoHelle
force-pushed
the
HP-894-apollo-update
branch
2 times, most recently
from
3253f95
to
2918602
Compare
The "useEffect"-hook calls the "onError" when error is present and object changes. After the Apollo client update, the error object is not the same object anymore, it changes on each render. If error is found, "onError" is called on each render, because useEffect is triggered Ref to the error object is now stored and cleared when "fetch" or "refetch" is called.
New kind of warning started to show up after Apollo client update: https://fb.me/setstate-in-render Child components caused parent component to re-render while parent was still rendering. Moved the triggering functions inside "useEffect" to delay them until rendering is done.
NikoHelle
force-pushed
the
HP-894-apollo-update
branch
from
2918602
to
33fa0ed
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
akikoskinen
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update caused few minor issues: