Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9620: Purge assets from varnish cache #70

Merged
merged 6 commits into from
Feb 23, 2024
Merged

UHF-9620: Purge assets from varnish cache #70

merged 6 commits into from
Feb 23, 2024

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Feb 20, 2024

How to install

How to test

  • Request any page and check the age header of that page
  • Wait for a couple of seconds and refresh the page again and make sure the age header has changed
  • Check the age header of any CSS / JS asset on that page and make sure the age returns a non-zero value
  • Run drush helfi:post-deploy && drush p:queue-work
  • Make sure the age header of CSS / JS assets was reset to zero, but the page's age header did not.
  • Make sure CSS url() contains the configured asset path

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (68dd382) to head (a9290c8).

❗ Current head a9290c8 differs from pull request most recent head c747b60. Consider uploading reports for the commit c747b60 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
+ Coverage     63.36%   68.66%   +5.30%     
  Complexity       82       82              
============================================
  Files            14       14              
  Lines           232      233       +1     
============================================
+ Hits            147      160      +13     
+ Misses           85       73      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think test failure is related to this.

Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants