Skip to content

Commit

Permalink
Merge pull request #61 from City-of-Helsinki/UHF-8198
Browse files Browse the repository at this point in the history
UHF-8198: Comment fixes
  • Loading branch information
tuutti authored Aug 11, 2023
2 parents d4d61a2 + d999722 commit 257e937
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ if ($varnish_port = getenv('DRUPAL_VARNISH_PORT')) {
$config['varnish_purger.settings.varnish_purge_all']['port'] = $varnish_port;
}
// Configuration doesn't know about existing config yet so we can't
// Configuration doesn't know about existing config yet, so we can't
// just append new headers to an already existing headers array here.
// If you have configured any extra headers in your purge settings
// If you have configured any extra headers in your purge settings,
// you must add them here as well.
$config['varnish_purger.settings.default']['headers'] = [
[
Expand Down
8 changes: 5 additions & 3 deletions src/HelfiProxyServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ class HelfiProxyServiceProvider extends ServiceProviderBase {
* {@inheritdoc}
*/
public function alter(ContainerBuilder $container) : void {
// PathProcessorLanguage and SitemapPathProcessor have same
// priority. Alter SitemapPathProcessor's priority so
// SitePrefixPathProcessor can be run in between the two.
// PathProcessorLanguage and SitemapPathProcessor have the same
// priority. Alter SitemapPathProcessor's priority, so
// SitePrefixPathProcessor can be run in between the two. Otherwise,
// the routes provided by 'simple_sitemap' path won't be recognized
// via the proxy path.
if ($container->hasDefinition('simple_sitemap.path_processor')) {
$definition = $container->getDefinition('simple_sitemap.path_processor');
$tags = $definition->getTags();
Expand Down
2 changes: 1 addition & 1 deletion src/PathProcessor/SitePrefixPathProcessor.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function processOutbound(
if ($options['language'] instanceof LanguageInterface) {
$language = $options['language']->getId();
}
// Use already resolved language to figure out active prefix
// Use an already resolved language to figure out active prefix
// since it might be different from content language.
$prefix = $this->sitePrefix->getPrefix($language);

Expand Down

0 comments on commit 257e937

Please sign in to comment.