Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10559: Add support for secondary key authentication #175

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 3, 2024

How to install

How to test

  • Run drush helfi:azure:pubsub-listen and make sure an authentication error is raised
  • Make sure the process works with secondary access key and doesn't die
  • Enter incorrect <secondary-access-key> and make sure the process fails with valid error code (echo $?)

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (0b9012a) to head (04724ee).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #175      +/-   ##
============================================
- Coverage     89.00%   88.94%   -0.06%     
+ Complexity      518      517       -1     
============================================
  Files            76       76              
  Lines          2064     2054      -10     
============================================
- Hits           1837     1827      -10     
  Misses          227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuutti tuutti marked this pull request as ready for review September 3, 2024 10:20
Copy link

sonarcloud bot commented Sep 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants