Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9239: Move ApiManager from helfi_navigation to helfi_api_base. #145

Merged
merged 11 commits into from
Jan 16, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jan 11, 2024

UHF-9239

What was done

Added base class for api clients. The code was originally developed for ApiManager in helfi_navigation module.

Install

Test

Other PRs

@hyrsky hyrsky force-pushed the UHF-9239-generic-api-manager branch 3 times, most recently from 902c053 to 65dd80f Compare January 11, 2024 06:49
@hyrsky hyrsky force-pushed the UHF-9239-generic-api-manager branch from bb89369 to c4ce2cd Compare January 11, 2024 06:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3428712) 66.19% compared to head (895b275) 67.38%.
Report is 1 commits behind head on main.

❗ Current head 895b275 differs from pull request most recent head 845167a. Consider uploading reports for the commit 845167a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #145      +/-   ##
============================================
+ Coverage     66.19%   67.38%   +1.18%     
- Complexity      514      540      +26     
============================================
  Files            69       73       +4     
  Lines          1784     1849      +65     
============================================
+ Hits           1181     1246      +65     
  Misses          603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky force-pushed the UHF-9239-generic-api-manager branch from 56a718e to 10f0ba0 Compare January 12, 2024 09:43
@hyrsky hyrsky force-pushed the UHF-9239-generic-api-manager branch from b9d0bf3 to 3d201cd Compare January 15, 2024 06:09
@hyrsky hyrsky requested a review from tuutti January 15, 2024 06:22
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants