Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link processor fixes #102

Merged
merged 7 commits into from
Apr 29, 2023
Merged

Link processor fixes #102

merged 7 commits into from
Apr 29, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Apr 27, 2023

How to install

  • composer require drupal/helfi_api_base:dev-UHF-X-test-fixes
  • drush cr

How to test

  • Add an "anchor" link (#anchor) to a textarea
  • Open the page with anchor link and check that no Failed to parse link: xxx errors are logged (docker compose logs app)

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #102 (99b0dc8) into main (c925987) will increase coverage by 9.58%.
The diff coverage is 0.00%.

❗ Current head 99b0dc8 differs from pull request most recent head 049c9c3. Consider uploading reports for the commit 049c9c3 to get more accurate results

@@             Coverage Diff              @@
##               main     #102      +/-   ##
============================================
+ Coverage     41.19%   50.77%   +9.58%     
+ Complexity      421      360      -61     
============================================
  Files            58       52       -6     
  Lines          1454     1223     -231     
============================================
+ Hits            599      621      +22     
+ Misses          855      602     -253     
Impacted Files Coverage Δ
...rc/EventSubscriber/EnsureApiAccountsSubscriber.php 0.00% <0.00%> (ø)
src/Link/UrlHelper.php 0.00% <0.00%> (ø)
src/Plugin/Filter/LinkConverter.php 11.32% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial problem of using #same-page-link works now - Good work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants