Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10062: config fixes #315

Merged
merged 3 commits into from
Jun 6, 2024
Merged

UHF-10062: config fixes #315

merged 3 commits into from
Jun 6, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jun 5, 2024

UHF-10062

What was done

Our automatic updates want to add translations to default contact form since it is included in webform/config/install. The translations override important webform handler settings.

See: 1b366e5.

This patch copies webform.webform.config to webform.webform.infofinland_config so we can manage translations ourselves.

  • Prevent automatic updates from overriding contact form handlers.
    • Add new webform infofinland_contact
    • Archive webform contact

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10062-config-fixes
    • make up shell
  • Run make drush-cr

How to test

  • Download latests artifact, simulate update config workflow with $(drush sql:connect) < latest.sql; drush cim -y; drush cr; drush locale:check; drush locale:update; drush cex -y. Config changes should look ok.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

Our automatic updates want to add translations to default contact
form since it is included in webform/config/install. The default
translations override important webform handler settings.

See: 1b366e5.

This patch copies `webform.webform.config` to
`webform.webform.infofinland_config` so we can manage translations
ourselves.
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyrsky hyrsky merged commit 7c983ad into dev Jun 6, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-10062-config-fixes branch June 6, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants