Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10025: Contact form bugfixes #304

Merged
merged 5 commits into from
May 7, 2024
Merged

UHF-10025: Contact form bugfixes #304

merged 5 commits into from
May 7, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented May 6, 2024 •
edited by rpnykanen
Loading

UHF-10025

What was done

  • Remove translations that override contact form email message
  • Determine feedback email address server side
  • Enable tests

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10025
    • make fresh
  • Run make drush-cr
  • Make sure your frontend is up and running on correct branch.
    • git checkout UHF-10025
    • yarn && yarn install

How to test

I tested this by adding breakpoint to EmailWebformHandler::sendMessage line 1167 and submitted feedback from frontend.

  • Setup frontend and try to submit feedback.
  • Check that code follows our standards.

Other PRs

@hyrsky hyrsky force-pushed the UHF-10025 branch 3 times, most recently from e80f7c4 to 2412519 Compare May 6, 2024 14:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyrsky hyrsky merged commit 975ebc4 into dev May 7, 2024
3 checks passed
@hyrsky hyrsky deleted the UHF-10025 branch May 7, 2024 07:56
@rpnykanen rpnykanen mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrsky @rpnykanen