Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to main #555

Merged
merged 59 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
d34b8c6
UHF-8706: correct comment
rpnykanen Aug 29, 2024
5000ad2
UHF-8706: initialize helfi_google_api module
rpnykanen Aug 29, 2024
db8f8e4
UHF-8706: initial module code
rpnykanen Aug 29, 2024
8bebe49
UHF-8706: add google's api library
rpnykanen Sep 4, 2024
14b875f
UHF-8706: intermediate commit with working index-check and single ite…
rpnykanen Sep 4, 2024
784144d
UHF-8706: enable module, added module settings config
rpnykanen Sep 4, 2024
ac4b180
UHF-8706: remove the helfi_google_api contrib module from core.extension
rpnykanen Sep 4, 2024
54dbbac
UHF-8706: add logger
rpnykanen Sep 5, 2024
f5f2543
UHF-8706: eventsubscriber to handle joblistings published by scheduler
rpnykanen Sep 5, 2024
315dc6c
UHF-8706: refactored by moving the logic to service, added docblocks
rpnykanen Sep 5, 2024
a0850bd
UHF-8706: added more docblocks, added url check code to the service
rpnykanen Sep 5, 2024
b833c51
UHF-8706: added temp redirect delete, removed useless code
rpnykanen Sep 5, 2024
3736ef3
UHF-8706: added command for remove-request, code fixes
rpnykanen Sep 6, 2024
0f75547
UHF-8706: override the key from env variables
rpnykanen Sep 6, 2024
dce9183
UHF-8706: get rid of \Drupal call
rpnykanen Sep 6, 2024
213dad0
UHF-8706: code fixes, changed eventsubscriber to use the better servi…
rpnykanen Sep 6, 2024
40527c4
UHF-8706: code fixes
rpnykanen Sep 6, 2024
f4f4a67
UHF-8706: comment must end with a full stop
rpnykanen Sep 6, 2024
3d527ee
UHF-8706: urlGenerator was missing for some reason
rpnykanen Sep 6, 2024
092d488
UHF-8706: phpstan fixes
rpnykanen Sep 6, 2024
69bb44b
UHF-8706: no need for logger here any more
rpnykanen Sep 6, 2024
01a8ad5
UHF-8706: fix services yml
rpnykanen Sep 6, 2024
c55c478
UHF-8706: less duplication
rpnykanen Sep 6, 2024
2ca0d96
UHF-8706: remove extra lines
rpnykanen Sep 6, 2024
2f69987
UHF-8706: use bool cast instead of double exlcamation
rpnykanen Sep 6, 2024
2fd0513
UHF-8706: qa fixes
rpnykanen Sep 6, 2024
cd9c38c
UHF-8706: key underscored
rpnykanen Sep 6, 2024
f963a65
UHF-8706: correct service name
rpnykanen Sep 6, 2024
5bc5d99
UHF-8706: delete redirect on deindex, delete redirect on failed index…
rpnykanen Sep 10, 2024
c563be5
UHF-8706: twig security update
rpnykanen Sep 10, 2024
a2533ea
Merge branch 'dev' into UHF-8706
rpnykanen Sep 10, 2024
1fc3c1d
UHF-8706: code fixes
rpnykanen Sep 10, 2024
3b8520b
UHF-8706: typos
rpnykanen Sep 10, 2024
a0f446e
UHF-8706: we don't want this to run in any environment until this has…
rpnykanen Sep 10, 2024
f713f07
UHF-8706: unused use statement
rpnykanen Sep 10, 2024
4b0eba4
UHF-8706: run only in production. added in a mention in main readme
rpnykanen Sep 10, 2024
00264a9
UHF-8706: add the readme update
rpnykanen Sep 10, 2024
41c7927
added env resolver to docblock
rpnykanen Sep 10, 2024
9d6a56d
UHF-8706: added missing comma
rpnykanen Sep 10, 2024
d4f2558
UHF-8706: added factory and updated services
rpnykanen Sep 10, 2024
6fb22ee
UHF-8706: added simple response class
rpnykanen Sep 10, 2024
c5ebd3d
UHF-8706: get rid of the simple prod check
rpnykanen Sep 10, 2024
24e8c24
UHF-8706: prevent sending actual request if key is not set or enabled…
rpnykanen Sep 10, 2024
c571b24
UHF-8706: less duplication
rpnykanen Sep 10, 2024
c59ce0b
UHF-8706: code fixes
rpnykanen Sep 10, 2024
5ce41b8
UHF-8706: renamed function with better name
rpnykanen Sep 11, 2024
5b15b08
UHF-8706: remove comment from eventsubscriber
rpnykanen Sep 11, 2024
c2a1575
UHF-8706: class description
rpnykanen Sep 11, 2024
af65219
UHF-8706: better command class name
rpnykanen Sep 11, 2024
6965aec
UHF-8706: code fixes
rpnykanen Sep 11, 2024
fc957cf
UHF-8706: function not used any more
rpnykanen Sep 11, 2024
7af6cb9
UHF-8706: status check debug function to use the dry run logic proper…
rpnykanen Sep 11, 2024
07e5165
UHF-8706: request debug to dryrun, fixed dryrun logic and fixed comme…
rpnykanen Sep 11, 2024
4249772
UHF-8706: feature is disabled by default in production
rpnykanen Sep 11, 2024
b635b4f
UHF-8706: concat requires space
rpnykanen Sep 11, 2024
4f329c9
UHF-8706: the is enabled check was wrong way
rpnykanen Sep 11, 2024
9a34eeb
UHF-8706: change enabled to dry_run
rpnykanen Sep 11, 2024
697ca13
UHF-8706: added return type
rpnykanen Sep 11, 2024
5cecabd
Merge pull request #552 from City-of-Helsinki/UHF-8706
rpnykanen Sep 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ local site.
4. To test the functionality, you should use the Mailpit running on your local in the `https://mailpit.docker.so/` url
to view the emails being sent by the feature.

#### Google indexing api automation (helfi_google_api-module)

Job listing urls are automatically sent to google indexing api
on publish and unpublish events, a request is sent to google to either index or deindex the url.

## Customizations

### Not part of global navigation
Expand Down
11 changes: 8 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"drupal/migrate_plus": "^6.0",
"drupal/raven": "^5.0",
"drupal/redis": "^1.5",
"drush/drush": "^12"
"drush/drush": "^12",
"google/apiclient": "^2.17"
},
"require-dev": {
"donatj/mock-webserver": "^2.4",
Expand Down Expand Up @@ -99,7 +100,10 @@
},
"patchLevel": {
"drupal/core": "-p2"
}
},
"google/apiclient-services": [
"Indexing"
]
},
"repositories": [
{
Expand All @@ -121,6 +125,7 @@
"copy-commit-message-script": "make copy-commit-message-script",
"post-install-cmd": [
"@copy-commit-message-script"
]
],
"pre-autoload-dump": "Google\\Task\\Composer::cleanup"
}
}
285 changes: 284 additions & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions conf/cmi/core.extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ module:
helfi_ckeditor: 0
helfi_etusivu_entities: 0
helfi_eu_cookie_compliance: 0
helfi_google_api: 0
helfi_hakuvahti: 0
helfi_image_styles: 0
helfi_media: 0
Expand Down
2 changes: 2 additions & 0 deletions conf/cmi/helfi_google_api.settings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dry_run: true
indexing_api_key: ''
Loading