Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10341 job page cache problem #529

Merged
merged 6 commits into from
Jul 30, 2024
Merged

UHF-10341 job page cache problem #529

merged 6 commits into from
Jul 30, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jul 25, 2024

UHF-10341

Joblisting start date cached as "today" and after a week, it would still say "today"

What was done

Moved the logic from template to javascript.

  • Created javacsript to handle the "today" text
  • Removed the old implementation from the template and code.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10341
    • make fresh
  • Run make drush-cr

How to test

  • Create a new job listing, set the startday or publish day or whatever to today
  • Save job listing
  • Load the job listing page
    • The javascript should load
    • The datetime in metadata-box under julkaistu-title should turn to "today"
  • Check that this feature works
  • Check that code follows our standards

Copy link

sonarcloud bot commented Jul 30, 2024

@khalima khalima merged commit 7eddb74 into dev Jul 30, 2024
2 checks passed
@khalima khalima deleted the UHF-10341 branch July 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants