Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8101: Update HDS package with normalize css fix #229

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Mar 28, 2023

UHF-8101

What was done

  • New HDS version has fix where Normalized CSS doesn't affect elements outside components anymore that made our H1 elements too small

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8101-update-hds-with-normalize-css-fix
    • make fresh
    • If you get an ERROR 1273 (HY000) at line 14784: Unknown collation: 'utf8mb4_0900_ai_ci' error with the database import, run make shell and then:
      • sed -i 's/utf8mb4_0900_ai_ci/utf8mb4_swedish_ci/g' dump.sql; drush sql-query --file=/app/dump.sql && drush helfi:oc:sanitize-database && drush cim -y;drush updb -y;drush cr;drush uli
  • Run make ps to get the correct proxy port for drupal-helfi-rekry-elastic. Should be 9200 but might change if you have multiple ES proxies running.
    • Edit the .env file and change the port in ELASTIC_PROXY_URL
    • Run make up again for the change to take effect
  • Run make drush-cr
  • Run make shell and then drush sapi-rt;drush sapi-i to make sure content is indexed properly

How to test

Designers review

  • This PR does not need designers review

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen self-requested a review March 29, 2023 08:03
@Jussiles Jussiles merged commit bbd5361 into dev Mar 29, 2023
@Jussiles Jussiles deleted the UHF-8101-update-hds-with-normalize-css-fix branch March 29, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants