UHF-7410: Language related accessibility fixes for job listings and job search #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuutti
reviewed
Mar 20, 2023
| ]; | ||
|
|
||
| // Use span instead of div for inline fields. | ||
| if ($variables['field_name'] && in_array($variables['field_name'], $inlineFields)) { |
There was a problem hiding this comment.
should the first if condition be isset($variables['field_name'])?
There was a problem hiding this comment.
Yeah, this should be fixed now
juho-lehmonen
force-pushed
the
UHF-7410-accessibility-language-fixes
branch
from
29e1a41
to
2fb98d7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tuutti
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-7410
This PR adds correct wrapping elements to lang parameters on job listing pages (spans for inline elements) and separates the language wrapper from the the translated "x jobs" text in job search results.
How to install
git checkout UHF-7410-accessibility-language-fixesmake freshmake shelland then:sed -i 's/utf8mb4_0900_ai_ci/utf8mb4_swedish_ci/g' dump.sql; drush sql-query --file=/app/dump.sql && drush helfi:oc:sanitize-database && drush cim -y;drush updb -y;drush cr;drush ulimake psto get the correct proxy port fordrupal-helfi-rekry-elastic. Should be 9200 but might change if you have multiple ES proxies running..envfile and change the port inELASTIC_PROXY_URLmake upagain for the change to take effectmake drush-crmake shelland thendrush sapi-rt;drush sapi-ito make sure content is indexed properlyHow to test
<span lang>element while the "x job" text should be wrapped with just a blank<span>element.<span>after the heading.Designers review