Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8102: job search metatags pt.2 #209

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Mar 8, 2023

UHF-8102

Improvements for adding custom metadata to job search task area pages

What was done

  • Add custom meta title and description creation for job search task area pages
  • Add meta description field for task area term
  • Add permissions to edit task area terms for admin
  • Update task area custom sitemap URLs

How to install

  • Make sure REKRY instance is up and running on correct branch.
  • git checkout UHF-8102-job-search-metatags

Setup for ES proxy

  • Run make ps to get the correct proxy port: drupal-helfi-rekry-elastic. Should be 9200 but might change if you have multiple ES proxies running.
  • Edit the .env file:
    • Change the port in ELASTIC_PROXY_URL

Make sure your instance is up-to-date:

  • make fresh
  • If you get an ERROR 1273 (HY000) at line 14784: Unknown collation: 'utf8mb4_0900_ai_ci' error with the database import, run make shell and then:
    • sed -i 's/utf8mb4_0900_ai_ci/utf8mb4_swedish_ci/g' dump.sql; drush sql-query --file=/app/dump.sql && drush helfi:oc:sanitize-database && drush cim -y;drush updb -y;drush cr;drush uli
  • Run these in the container to update Elastic indexes:
drush sapi-rt
drush sapi-i
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else worked really well except the sitemap thing. There isn't entries like mentioned there :(

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this one works 🦖

@Jussiles Jussiles merged commit d4e8d70 into dev Mar 9, 2023
@Jussiles Jussiles deleted the UHF-8102-job-search-metatags branch March 9, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants