Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7999: Move hardcoded search page node id to settings form. #202

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Feb 22, 2023

UHF-7999

What was done

This PR moves a hardcoded value to Rekry's settings form.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-7999-add-search-page-to-settings
    • make fresh
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen marked this pull request as ready for review February 22, 2023 10:09
@juho-lehmonen juho-lehmonen marked this pull request as draft February 22, 2023 10:09
@juho-lehmonen juho-lehmonen changed the title Draft: UHF-7999: Move hardcoded search page node id to settings form. UHF-7999: Move hardcoded search page node id to settings form. Feb 22, 2023
@juho-lehmonen juho-lehmonen marked this pull request as ready for review February 22, 2023 10:21
@dire dire self-requested a review February 23, 2023 11:47
Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described! 👍

@juho-lehmonen juho-lehmonen merged commit 52f000e into dev Feb 24, 2023
@juho-lehmonen juho-lehmonen deleted the UHF-7999-add-search-page-to-settings branch February 24, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants