Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7964: updated breadcrumb configurations to match all the other sites #182

Merged
merged 1 commit into from
Jan 24, 2023
Merged

UHF-7964: updated breadcrumb configurations to match all the other sites #182

merged 1 commit into from
Jan 24, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jan 23, 2023 •
edited by jira bot
Loading

UHF-7964

Updated breadcrumb configurations

What was done

  • On subpages, breadcrumb used to be wrong: etusivu > alasivu
  • Now it's fixed to: etusivu > avoimet työpaikat > alasivu

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-7964_breadcrumb_configuration
    • make fresh
  • Run make drush-cr

How to test

  • Click any link on menu
  • Check breadcrumb.
    • Breadcrumb should be in this format: etusivu > avoimet työpaikat > alasivu
    • Check with all languages. Second link should always be either avoimet työpaikat or open jobs or lediga jobb

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

khalima
khalima approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚀

@rpnykanen rpnykanen merged commit 0b00779 into dev Jan 24, 2023
@rpnykanen rpnykanen deleted the UHF-7964_breadcrumb_configuration branch January 24, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @khalima