Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhf 5254: Employment dropdown #150

Merged
merged 6 commits into from
Dec 30, 2022
Merged

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 19, 2022

UHF-5254

Add dropdown for employment options + backend logic for indexing.

What was done

  • Add jotai store for combined employment / employment type options (with predefined list of options)
  • Make initial aggs request into _msearch request that gets bot aggs and queries indexed taxonomy terms
  • Add logic for rendering dropdown / filter pills
  • Pass url params correctly
  • Add forming query from selections

How to install

Make sure your instance is up and running on correct branch.

  • git fetch; git checkout origin/UHF-5254-employment-dropdown
  • make fresh OR make drush-cr; make drush-cim;
  • Run make drush-cr

Set up your index:
Env;

  • Run make ps. Note the port that your drupal-helfi-rekry-elastic container is running in.
  • Add ☝️ to your .env as the ELASTIC_PROXY_URL variable (http:localhost:{port-elastic-runs-in})
  • Run make up
  • make shell into the container. Verify that your ELASTIC_PROXY_URL is set by running printenv | grep ELASTIC_PROXY_URL

Elastic:

How to test

Frontpage form:

Full search page:

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeremysteerio jeremysteerio merged commit 95332f2 into dev Dec 30, 2022
@jeremysteerio jeremysteerio deleted the UHF-5254-employment-dropdown branch December 30, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants