Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7444: Added condition around pay-metadata field printing #125

Merged
merged 2 commits into from
Nov 22, 2022
Merged

UHF-7444: Added condition around pay-metadata field printing #125

merged 2 commits into from
Nov 22, 2022

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 18, 2022 •
edited
Loading

UHF-7444

What was done

  • Pay-information is hidden if there is no value given to it.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-7444_hide_salary_information_when_not_provided
    • composer require drupal/hdbt:dev-UHF-7444_hide_salary_information_when_not_provided
    • make fresh
  • Run make drush-cr

How to test

  • Go to edit any job listing content and remove the Salary field content and save the node.
  • There shouldn't have anymore "Pay"-information with "-" as value written on the node metadata box.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Other PRs

@teroelonen teroelonen mentioned this pull request Nov 18, 2022
Merged
2 tasks
@teroelonen teroelonen marked this pull request as ready for review November 18, 2022 13:25
lonkaanna
lonkaanna approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@lonkaanna lonkaanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teroelonen teroelonen merged commit 40b4ca2 into dev Nov 22, 2022
@teroelonen teroelonen deleted the UHF-7444_hide_salary_information_when_not_provided branch November 22, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonkaanna lonkaanna lonkaanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @lonkaanna