Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-5923: Job listing search fallback #118

Merged
merged 7 commits into from
Nov 14, 2022
Merged

UHF-5923: Job listing search fallback #118

merged 7 commits into from
Nov 14, 2022

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 11, 2022 •
edited by Jussiles
Loading

UHF-5923

What was done

  • Added job listing search fallback view
  • Created job listing search paragraph and added it to landing page

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-5923_job_listing_search_fallback
    • make fresh
  • Run make drush-cr

How to test

  • Create a landing page and add the job listing search paragraph to it. Save the node.
  • Go to view the node and make sure the fallback listing works without javascript and looks good. Notice that the design of the job listing card has changed and it affects the "You might be interested block" on single job listing page as well.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Sami Haikonen)

@teroelonen teroelonen marked this pull request as ready for review November 11, 2022 15:32
@Jussiles Jussiles self-requested a review November 14, 2022 08:04
Jussiles
Jussiles approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and work good! 🦜 Fix the comments that I added and you can merge.

public/modules/custom/helfi_rekry_content/helfi_rekry_content.module Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_job-listing-search.scss Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teroelonen teroelonen merged commit 60845da into dev Nov 14, 2022
@teroelonen teroelonen deleted the UHF-5923_job_listing_search_fallback branch November 14, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @Jussiles