UHF-10012: Map vault accounts individually, UHF-10015: Stage file proxy default URL #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuutti
changed the title
|
hyrsky
reviewed
Apr 25, 2024
| // @see https://github.com/City-of-Helsinki/drupal-module-helfi-api-base/blob/main/documentation/api-accounts.md. | ||
| if ($vault_accounts = getenv('DRUPAL_VAULT_ACCOUNTS')) { | ||
| $config['helfi_api_base.api_accounts']['vault'] = json_decode(base64_decode($vault_accounts), TRUE); | ||
| if ($drupal_navigation_vault = getenv('DRUPAL_NAVIGATION_VAULT')) { |
There was a problem hiding this comment.
I think DRUPAL_PUBSUB_VAULT and DRUPAL_NAVIGATION_VAULT should be added to preflight checks at least on core instances (and DRUPAL_API_ACCOUNTS and DRUPAL_VAULT_ACCOUNTS should be removed).
There was a problem hiding this comment.
Sure, but we have to add them manually to all.settings.php, since we can't really differentiate instances in settings.php. Unless I am missing something
hyrsky
approved these changes
Apr 30, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.