Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10452: Change the news list news archive base url #795

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 23, 2024

NOTICE!

When this PR is merged and deployed to testing the following changes need to be made manually to front page instance:

  • Change the current news archive url to /news/archive / /uutiset/arkisto / /nyheter/arkiv
  • Create a new landing page called Current and have it on the /news / /uutiset / /nyheter path.

UHF-10452

What was done

  • Changed the news archive base url to /news/archive.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10452
  • Run make drush-cr

How to test

  • Check that the news list block link in English leads to /news/archive url with the parameters at the end of the url.
  • Check that the news list block link in Finnish leads to /uutiset/arkisto url with the parameters at the end of the url.
  • Check that the news list block link in Swedish leads to /nyheter/arkiv url with the parameters at the end of the url.
  • Check the front page functionality as well from the front page instance PR.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to the required files and included in this PR.

Other PRs

Copy link

sonarcloud bot commented Aug 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants