Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Helfi test content update #750

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Apr 23, 2024

What was done

  • Fixed ckeditor buttons on test content
  • Added test content for all branding colours

How to install

  • Build a new test-site
    • composer create-project City-of-Helsinki/drupal-helfi-platform:dev-main test --no-interaction --repository https://repository.drupal.hel.ninja/
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_helfi_test_content_update
  • Get the site up and running
    • make new
  • Run make shell
    • In shell run drush en -y helfi_test_content

How to test

  • Check that there is a new page for DC: Colors
  • Check that code follows our standards

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (b57b267) to head (cdd54b7).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #750   +/-   ##
=========================================
  Coverage     14.96%   14.96%           
  Complexity      258      258           
=========================================
  Files            31       31           
  Lines           982      982           
=========================================
  Hits            147      147           
  Misses          835      835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works correctly! 🦖

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I found out that the coat of arms is in the wrong color. Need to fix that.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color palette fixed, this is good to go 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants