Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9761: Remove user_inquiry code #713

Merged
merged 5 commits into from
Mar 18, 2024
Merged

UHF-9761: Remove user_inquiry code #713

merged 5 commits into from
Mar 18, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 14, 2024

UHF-9761

What was done

  • Removed all user_inquiry related code.
  • Updated the cookie compliance information to exclude the Nordstat local storage rows.
  • Updated cookie compliance version number.
  • Updated the chat leijuke version number.

How to install

  • Make sure your instance is up and running on latest dev branch. I use SOTE in the testing instructions.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9761
  • Run make drush-updb drush-cr

How to test

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.02%. Comparing base (9d7def6) to head (b907183).

❗ Current head b907183 differs from pull request most recent head c1df23c. Consider uploading reports for the commit c1df23c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #713      +/-   ##
============================================
+ Coverage     13.01%   13.02%   +0.01%     
  Complexity      242      242              
============================================
  Files            28       28              
  Lines           945      944       -1     
============================================
  Hits            123      123              
+ Misses          822      821       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teroelonen teroelonen changed the title UHF-9761: Remove all user_inquiry code that I could find UHF-9761: Remove user_inquiry code Mar 14, 2024
@teroelonen teroelonen marked this pull request as ready for review March 14, 2024 13:50
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants