Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9274: Change Telia ACE widget embed element #659

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Dec 1, 2023

UHF-9274

What was done

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9274-telia-ace-button-improvement
  • Run make drush-cr
  • Create a new page or landing page for testing with swedish and english translations
  • Add a new Telia ACE block to the Attachments region with the following values:
    • Hide the title
    • Script URL: /wds/instances/J5XKjqJt/ACEWebSDK.min.js
    • Chat ID: local-chat-asiointi-eng
    • Translate the block and change the chat ID:
      • Finnish: local-chat-asiointi-fin
      • Swedish: local-chat-asiointi-sve

How to test

  • Check that this feature works on the page where the block is visible:
    • View the page source, make sure the <div class="hidden" id="humany_local-chat-asiointi"></div> element is there
    • The ACEWebSDK.min.js script is embedded on the page and has the async parameter
    • The window.chat_user_consent object is available on the page
  • Check that code follows our standards

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d0379a5) 13.15% compared to head (36c34b9) 13.07%.
Report is 8 commits behind head on main.

❗ Current head 36c34b9 differs from pull request most recent head e103711. Consider uploading reports for the commit e103711 to get more accurate results

Files Patch % Lines
src/Plugin/Block/TeliaAceWidget.php 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #659      +/-   ##
============================================
- Coverage     13.15%   13.07%   -0.09%     
  Complexity      241      241              
============================================
  Files            28       28              
  Lines           935      941       +6     
============================================
  Hits            123      123              
- Misses          812      818       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juho-lehmonen juho-lehmonen marked this pull request as ready for review December 1, 2023 12:37
@juho-lehmonen juho-lehmonen changed the title UHF-9274: Change anchor element to button. UHF-9274: Change Telia ACE widget embed element Dec 1, 2023
Copy link
Contributor

@rpnykanen rpnykanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving "Display title" selection activated causes a huge white block under footer.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants