Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9113 Drupal10 bug fixes #630

Merged
merged 5 commits into from
Nov 2, 2023
Merged

UHF-9113 Drupal10 bug fixes #630

merged 5 commits into from
Nov 2, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 1, 2023

UHF-9113

What was done

  • Fix PHP 8.2 deprecation issue with PublishedAtOrNowComputed
  • Updated Gin toolbar

How to install

  • Make sure your D10 (Kasko) instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9113-drupal10-bug-fixes -W
  • Run make drush-updb drush-cr

How to test

  • Check that the Gin toolbar works as before
  • Check that code follows our standards

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (4.x@946cf04). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a91a6e1 differs from pull request most recent head db28373. Consider uploading reports for the commit db28373 to get more accurate results

@@          Coverage Diff           @@
##             4.x     #630   +/-   ##
======================================
  Coverage       ?   13.29%           
  Complexity     ?      241           
======================================
  Files          ?       30           
  Lines          ?      910           
  Branches       ?        0           
======================================
  Hits           ?      121           
  Misses         ?      789           
  Partials       ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khalima khalima merged commit 4b1f423 into 4.x Nov 2, 2023
4 checks passed
@khalima khalima deleted the UHF-9113-drupal10-bug-fixes branch November 2, 2023 14:41
@khalima khalima restored the UHF-9113-drupal10-bug-fixes branch November 2, 2023 14:47
@khalima khalima deleted the UHF-9113-drupal10-bug-fixes branch February 8, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants