Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8080: WatsonAdapter chat bug fix #448

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 1, 2023

UHF-8080

What was done

  • Added additional interval on top of the timeout to tackle issues with slower connections.

How to install

  • Make sure your asuminen instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8080_watson_chat_opening_issue_fix
  • Run make drush-cr

How to test

  • Go to https://helfi-asuminen.docker.so/fi/asuminen/vuokra-asunnot
  • On your inspectors Network tab select to throttle the download speed to Slow 3G.
  • Clear page cookies.
  • Refresh the page where the chat is and accept only compulsory cookies.
  • Click on the chat and make sure it opens with first click.
  • Close the chat so that there is no more popup visible.
  • Open the chat again and close it once more.
  • Refresh the page and make sure the chat opens again nicely.
  • Clear the page cookies again.
  • Refresh the page where the chat is and accept all cookies.
  • Click on the chat and make sure it opens with first click.
  • Close the chat so that there is no more popup visible.
  • Open the chat again and close it once more.
  • Refresh the page and make sure the chat opens again nicely.
  • Check that code follows our standards

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen self-requested a review March 1, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants