Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8071: Use new version of IBM chat embed. #444

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Feb 21, 2023

UHF-8071

This PR adjusts the IBM Chat App block to use the new embed code.

What was done

Changed the embed code to the latest version which uses just one JS file instead of three.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8071-new-ibm-chat-app
  • Run make drush-cr
  • Add a new IBM Chat App on /admin/structure/block to the Attachments region with the following info:

How to test

  • Open the page you added the block to and accept cookies
  • The chatbot button should show up
  • Click the button
  • Check the JS console in the browser's developer toolbar. There should be a bunch of debug information prefixed with [ACA], but there shouldn't be any JS errors or messages about deprecated URLs

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen changed the title Draft: UHF-8071: Use new version of IBM chat embed. UHF-8071: Use new version of IBM chat embed. Mar 3, 2023
@juho-lehmonen juho-lehmonen marked this pull request as ready for review March 3, 2023 08:26
@xkhaven xkhaven self-requested a review March 6, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants