Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Add missing translation for cookie banner text #416

Merged
merged 2 commits into from
Dec 21, 2022
Merged

UHF-X Add missing translation for cookie banner text #416

merged 2 commits into from
Dec 21, 2022

Conversation

teroelonen
Copy link
Contributor

Missing translations for cookie banner

What was done

  • Added missing translations for cookie banner.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git checkout origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_add_missing_translation_for_cookie_banner
  • Run make shell
  • Run drush locale:check; drush locale:update; drush cr

How to test

  • Check that the cookie banner text string is translated. This issue was present in local version of form-tool so might be that this is not an visible issue on other instances.
  • Check that code follows our standards

Other PRs

  • Link to other PR

khalima
khalima approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teroelonen teroelonen merged commit a7b3be8 into main Dec 21, 2022
@teroelonen teroelonen deleted the UHF-X_add_missing_translation_for_cookie_banner branch December 21, 2022 12:34
This was referenced Dec 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@hel-platta-automation hel-platta-automation mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima