UHF-7741: prevent wsod by checking that the field exists #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ltpk
approved these changes
Dec 13, 2022
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-7741
Announcement module tried to get value out of non-existing field.
What was done
Added checks to prevent getting values out of non-existing field.
How to install
git pull origin devmake freshcomposer require drupal/helfi_platform_config:dev-UHF-7741_announcement_wsod_bugmake drush-updb drush-crHow to test
Ota etusivun instanssista viimeisin versio ja mene muokkaamaan Poikkeusilmoitus sisältötyypin “Show on content pages” kenttää https://helfi-etusivu.docker.so/fi/admin/structure/types/manage/announcement/fields/node.announcement.field_announcement_content_pages ja laita News item sallituksi sisältötyypiksi. Tallenna.
Mene luomaan kaksi poikkeusilmoitusta: Minä tein Varoituksen ja Ilmoituksen joista Varoituksen laitoin aktiiviseksi kaikille sivuille ja Ilmoituksen laitoin aktiiviseksi yhdelle uutiselle.
Mene nyt uutissivulle jossa pitäis näkyä kaksi ilmoitusta