Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New TPR service list component with search #407

Merged
merged 22 commits into from
Mar 1, 2023
Merged

New TPR service list component with search #407

merged 22 commits into from
Mar 1, 2023

Conversation

dragos-dumi-ibm
Copy link

@dragos-dumi-ibm dragos-dumi-ibm commented Nov 25, 2022 •
edited by jira bot
Loading

PLAENH-185

UHF-7656

New TPR service list component with search

What was done

More details at
https://helsinkisolutionoffice.atlassian.net/browse/PLAENH-185

How to install

How to test

Add to a page that has paragraphs the new component "Service List Search"
Configure the component with using service_id and/or specific services

Other PRs

dragos-dumi-ibm and others added 8 commits November 3, 2022 08:59
@dragos-dumi-ibm @oviag
PLAENH-185 Create service list search paragraph type
0f0afe7 
* added service_list_search paragraph type and configured fields

* enabled service list paragraph on content region in landing page

* added translations for new paragraph fields labels

* changed comment in config install

Co-authored-by: ovidiu <ovidiu.ardelean@ibm.com>
@ArseneClaudiu @oviag @dragos-dumi-ibm
PLAENH-185 - service list views search and search teaser config
c680ea4 
* added configuration files for view mode teaser search result

* added view service_list to config install

* removed uuids from some config isntall + fix enable teaser search result + install views new block

* Several updates on config for service list search

* updated widget for errand service

Co-authored-by: ovidiu <ovidiu.ardelean@ibm.com>
Co-authored-by: Dragos Dumitrescu <dragos.dumitrescu@ibm.com>
Co-authored-by: Arsene Claudiu Ion <arseneclaudiuion@192-168-0-179.rdsnet.ro>
@dragos-dumi-ibm
Merge branch 'City-of-Helsinki:main' into main
ccb7031
@dragos-dumi-ibm
Merge branch 'City-of-Helsinki:main' into main
8d1aeda
@dragos-dumi-ibm @oviag
added placeholder and title with translations for service list search (…
eeccdea 
…#5)

* added placeholder and title with translations for service list search

* reverted some changes on views list defau;t

* Fix views search list translations update

* fix service errand service formatter in search list

Co-authored-by: ovidiu <ovidiu.ardelean@ibm.com>
@ArseneClaudiu
updated config (#6)
c0cb11e 
* updated config

* added settings with label

Co-authored-by: Arsene Claudiu Ion <arseneclaudiuion@192-168-0-179.rdsnet.ro>
@ArseneClaudiu
add translations for service channel types formatter
c9a489b 
* add formatter translations for formatter

* added translated config to updatehook 30

* fixed translation install

Co-authored-by: Arsene Claudiu Ion <arseneclaudiuion@192-168-0-179.rdsnet.ro>
@dragos-dumi-ibm
Merge branch 'City-of-Helsinki:main' into main
3cab6e3
@dragos-dumi-ibm dragos-dumi-ibm mentioned this pull request Nov 25, 2022
Merged
5 tasks
@tuutti
Copy link
Member

tuutti commented Nov 29, 2022

The search bar seems to work when I open the Views display manually (/admin/structure/views/view/service_list/edit/block_1), but not on actual paragraph page:

image

image

@dragos-dumi-ibm
Copy link
Author

dragos-dumi-ibm commented Nov 29, 2022 •
edited
Loading

@tuutti
If there are less than 5 services, the total count and search bar won't show (it was a requirement) This condition is done only for the front-end theme, that's why is different in views preview in admin.
Let me know if that info solves the issue. Thanks

@tuutti
Copy link
Member

tuutti commented Nov 29, 2022

Ah, makes sense. Seems to work now

@dragos-dumi-ibm
Copy link
Author

@tuutti I've found the issue you mentioned on slack with the uncachable. was due to this filter in views

b191aef

@juho-lehmonen juho-lehmonen self-requested a review February 3, 2023 09:12
@juho-lehmonen
Copy link
Contributor

Codewise this looks good and is working as described. We're asking for feedback from the UX team and Aleksi about how the paragraph works on the editor side (might need some additional help texts and a better widget for the service grouping IDs). I'll comment here as soon as possible if something needs to be fixed.

juho-lehmonen
juho-lehmonen requested changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you edit a service with the "Override: name" field, the title is correctly changed in the search results, but it's not included in the search. If you try searching with the overridden name, you can't find the service.

@dragos-dumi-ibm
Copy link
Author

@juho-lehmonen thanks for the review. We've included also the override title in the search

  • we've updated the field label and description as commented yesterday on PLAENH-185

juho-lehmonen
juho-lehmonen approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the fixes! This can be merged after the conflicts have been resolved.

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dragos-dumi-ibm
Copy link
Author

@juho-lehmonen the conflicts have been fixed.

@juho-lehmonen
Copy link
Contributor

@juho-lehmonen the conflicts have been fixed.

Great, I'll merge this.

@juho-lehmonen juho-lehmonen merged commit 78a5d9a into City-of-Helsinki:main Mar 1, 2023
This was referenced Mar 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juho-lehmonen juho-lehmonen Awaiting requested review from juho-lehmonen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dragos-dumi-ibm @tuutti @juho-lehmonen @ArseneClaudiu @oviag