New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Fix cookie dialog Power BI charts logic #398

Merged

Arkkimaagi merged 1 commit into main from UHF-X_minor_bug_fixes

Nov 15, 2022

Contributor

Arkkimaagi commented Nov 14, 2022

UHF-X

Fix MS Power BI cookie logic

What was done

Switched from hiding iframe to rendering it only when appropriate

How to install

Make sure your instance is up and running on latest dev branch.
- git pull origin dev
- make fresh
Update the Helfi Platform config
- composer require drupal/helfi_platform_config:dev-UHF-X_minor_bug_fixes
Update HDBT using UHF-X: Minor fixes drupal-hdbt#480
Run make drush-updb drush-cr

How to test

Test in HDBT PR

Other PRs

UHF-X: Minor fixes drupal-hdbt#480


          UHF-X: Fix cookie dialog Power BI charts logic

442c97e

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Arkkimaagi mentioned this pull request

UHF-X: Minor fixes City-of-Helsinki/drupal-hdbt#480

Merged

6 tasks

ltpk approved these changes

View reviewed changes

Arkkimaagi merged commit 9e76190 into main

Arkkimaagi deleted the UHF-X_minor_bug_fixes branch

November 15, 2022 08:18

hel-platta-automation mentioned this pull request

Automatic update City-of-Helsinki/drupal-helfi-kymp#527

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet