Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9354 Node packages #317

Merged
merged 4 commits into from
Nov 24, 2023
Merged

UHF-9354 Node packages #317

merged 4 commits into from
Nov 24, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 23, 2023 •
edited by teroelonen
Loading

UHF-9354

What was done

  • Updated HDBT subtheme node version to 20.10.0
  • Updated HDBT subtheme node modules and webpack.svgToSprite.js to match HDBT theme.

How to test

  • (optional) Run nvm use && npm i && npm run build in ./public/themes/custom/hdbt_subtheme and check for possible changes. There shouldn't be any though.
  • Check the changed files for possible errors

Other PRs

This was referenced Nov 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
teroelonen
teroelonen approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🦖

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khalima khalima merged commit ce4d666 into dev Nov 24, 2023
3 checks passed
@khalima khalima deleted the UHF-9354_node_packages branch November 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen