Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9180: Add additonal information on event card #898

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 26, 2024

UHF-9180

What was done

  • Add ne information check for offers info url and based on t…hat information print additional information to event cards

How to install

  • Make sure your instance is up and running on latest dev branch. For example the ELO instance is good for testing this.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9180
  • Run make drush-cr drush-locale-update drush-cr

How to test

  • Go to https://helfi-elo.docker.so/fi/yritykset-ja-tyo/business-helsingin-tapahtumat or any other page that includes events.
  • Now you should notice that at least some events (could be even all of them) should have additional information indicating that the event needs registration prior to attending. This is based on the API value offers info_url so if this information is present there should be this additional information and if not then the event doesn't require registration or a ticket.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@teroelonen teroelonen marked this pull request as ready for review January 29, 2024 07:35
@hyrsky hyrsky self-requested a review January 29, 2024 09:46
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants