Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9107: Unified button placement on filter searches #879

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 16, 2024

UHF-9107

What was done

  • Submit button on unit searches was moved below the filters on all cases.
  • Description for inputs was styled a bit to avoid large gap between the input and description.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9107
  • Run make drush-cr

How to test

Designers review

  • This PR has been visually reviewed by a designer (Nina Hiukkanen)

Other PRs

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something 🐟 with the button order as it is under the filters on mobile and on top in desktop. See images below.

Mobile
image

Desktop
image

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! All forms looks similar now and are accessible. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants